Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbbEILpH (ORCPT ); Sat, 9 May 2015 07:45:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46006 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750909AbbEILpE (ORCPT ); Sat, 9 May 2015 07:45:04 -0400 Date: Sat, 9 May 2015 13:44:28 +0200 From: Maxime Ripard To: Jens Kuske Cc: Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Message-ID: <20150509114428.GV11057@lukather> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-6-git-send-email-jenskuske@gmail.com> <20150506121941.GD11057@lukather> <554A7DE5.6040406@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OlucDFihBVSxvK/7" Content-Disposition: inline In-Reply-To: <554A7DE5.6040406@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3442 Lines: 98 --OlucDFihBVSxvK/7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 06, 2015 at 10:47:33PM +0200, Jens Kuske wrote: > >> + * You should have received a copy of the GNU General Public > >> + * License along with this file; if not, write to the Free > >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, > >> + * MA 02110-1301 USA > >=20 > > Could you remove that last paragraph? > > It generates a checkpatch warning. >=20 > Sure, will be removed. Just copied it from some other sunxi dtsi. Yeah, I know, I'm even the one that introduced this in the first place :) I sent a patch earlier this week to remove it from the other DT. > >> + ahb12_rst: reset@01c202c0 { > >> + #reset-cells =3D <1>; > >> + compatible =3D "allwinner,sun6i-a31-clock-reset"; > >> + reg =3D <0x01c202c0 0xc>; > >> + }; > >=20 > > This reset controller also resets the timers, it should be initialised > > much earlier. > >=20 > > What about having an allwinner,sun8i-h3-bus-reset, and adding it to > > the list of compatibles to initialise earlier in > > drivers/reset/reset-sunxi.c? > >=20 > > Of course, it would cover the other reset controllers that you have > > below. > >=20 >=20 > You mean using a single bus_rst instead of the three? Yes. > Or, why not using allwinner,sun6i-a31-ahb1-reset for ahb12_rst Strictly speaking, they do not control the same set of devices. I'd prefer to have a different compatible in case we need to setup a particular behaviour on a given SoC (for example, force out of reset a particular device, even if no driver is actually using it), without impacting the other. > and adding a .init_time =3D sun6i_timer_init to the sun8i machine. But we will need to do that yes. > I'm a bit confused here now, because for A23, which is almost > identical, it got removed after your comment: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/265064.ht= ml Hmmmm, I think I somehow overlooked the fact that the timer was there, even though Chen-Yu said it. My bad :/ Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --OlucDFihBVSxvK/7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVTfMcAAoJEBx+YmzsjxAgPPQQAIuQ8y5sW1pX54nayUu9xjer Z6ccEk2LrtmjB42C5Wndvz58z0ERHsVrvbseRDtWC/C9AA2g195I/RiCXT6AVrI5 vlMJJ4ZekiQvc/fS2M+zUMizSL1GVM9INR/8YsItKyNpe28ncYrdM9F7YiL/oI35 NRJDRqInOoZqJABHLmYDR2MZ7vlletKy+STR2lVxQqhaIoA9gJVe2UczM7hVEVqn djAWOXEEU9R9TmuihMx9u4zN1ZFEwci2l83YF6OcEttRfPFSeb9ot8pDFxOIi5xt tTkVtsjfKtoDOue8XPKip0M7Qy4BUP9DcBNm3DRBgmYWadOI8rUk05E8aaXiqDxu wwAzl6UWtn6S2nriLB+EPImbR1IffC+eskJ3sccD+2LILQjuocM1+kRiRz900Is+ gGFbmSMCtugV5HUwdWMboC8nJX/EZAMVmGTd1bG4sKJDW8+c9xjbDdp+UiOJy5Wn 9YfECw61kVGpyLCFVojivYKdfrkNphlqDcrNzUlWuZNbMY2NA2GOL5uw1dwloe3P Bs9kYgErtrk44ZSsk96AN6ijmpnfavzqBEdZGPaaO3IlWC2dDe91o44FJ4YkT3Sh daFLQKNWKFC9fwVaHrBv+UZ0mRuceRVjR3UUf4feONrNpf91T63DzT5jOpX+rNhj szcVezqDNU8LA+dzyYfu =aStI -----END PGP SIGNATURE----- --OlucDFihBVSxvK/7-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/