Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbbEIMUI (ORCPT ); Sat, 9 May 2015 08:20:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46189 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750842AbbEIMUF (ORCPT ); Sat, 9 May 2015 08:20:05 -0400 Date: Sat, 9 May 2015 14:19:36 +0200 From: Maxime Ripard To: Jens Kuske Cc: Paul Bolle , Emilio =?iso-8859-1?Q?L=F3pez?= , Mike Turquette , Linus Walleij , Vinod Koul , Rob Herring , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Message-ID: <20150509121936.GW11057@lukather> References: <1430904693-1404-1-git-send-email-jenskuske@gmail.com> <1430904693-1404-4-git-send-email-jenskuske@gmail.com> <1430986247.8171.37.camel@x220> <554DD0BF.9080108@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fCmRXBY78W5odcVA" Content-Disposition: inline In-Reply-To: <554DD0BF.9080108@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2424 Lines: 66 --fCmRXBY78W5odcVA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 09, 2015 at 11:17:51AM +0200, Jens Kuske wrote: > >> +MODULE_DEVICE_TABLE(of, sun8i_h3_pinctrl_match); > >=20 > >> +MODULE_AUTHOR("Jens Kuske "); > >> +MODULE_DESCRIPTION("Allwinner H3 pinctrl driver"); > >> +MODULE_LICENSE("GPL"); > >=20 > > This adds some module specific boilerplate. Was it perhaps your > > intention to make PINCTRL_SUN8I_H3 a tristate symbol? > >=20 >=20 > I don't know to be honest, I just followed the pattern of all the other > pinctrl-sun?i-*.c files. But it sounds logical that this is needless > in the current state. >=20 > Looks like it got introduced when splitting up the driver: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/251712.h= tml >=20 > Maybe there were plans to use separate modules some day. If not, we > should remove it from the other files as well I guess. Maxime, could > you please comment on that? I don't see anything wrong with building those as modules. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --fCmRXBY78W5odcVA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVTftYAAoJEBx+YmzsjxAgOuQP/jwGCTKZwx7m9+J+lgA0KKDm eEW5WUZV80oJsbCv6s9+pyyrlyL9XLRPmHffsRUZIYKBIUE7K5LbRZwllsnwrsQ4 tqb24MndFdNxTqXK/QZY7tZHMlTyHA89beGILc76Bo12u30Cc4RAzTM499k//JKt UlLuTqTDIiF5L9WB0KCKw5Cabk0pS+321zlGaEpcPmsG3QMmgaxAy7pAGDpAfsrJ 2kn5580N2i0clDOXWsPaoTbHHYEInc3l8uOE5jY2553WO+4IFTeD8t1m6tSVAK6T HbkB/MGiOZUVmjwDdtn1X7U+w0J+GT5lQTNaYnXIUXDy5wKrc0961+1UplvttF7w f5vfGUaVNxhsNOIcgs1qjLjeItpNw/Uczz5psBtklBewoxjn9zsfhhMP2CqqFT+d sT5SoSvXxRxhnyEBIFcv8A0TRb3+aZpm2ceXNNPnY7HCUb5rHjvKeWtc1r2EZTpT rhVrD2VVzJppbxX/5ZRfikKP2Zd9erTr+2SHT4OCoFZt4D9QNu8t6PJXkREfGcTm 1S3/U3o34er7CBIiepj0pVmE4V7r+XRAAP+lKMv9umlo/6OWhrW0Wx358N98Q65Y GTUUoc7beuJwZaIg7Da8yIVzwJB8SoKSSwoM0US8d1NpvZGoIBpdnNfN+2sfCAl4 5get/wXAsG2gGt7iDZr7 =Ubnn -----END PGP SIGNATURE----- --fCmRXBY78W5odcVA-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/