Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752154AbbEIV7H (ORCPT ); Sat, 9 May 2015 17:59:07 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:34275 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050AbbEIV7D (ORCPT ); Sat, 9 May 2015 17:59:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150509211746.GY2067@n2100.arm.linux.org.uk> References: <1431204728-16754-1-git-send-email-tremyfr@gmail.com> <20150509211746.GY2067@n2100.arm.linux.org.uk> Date: Sat, 9 May 2015 18:59:01 -0300 Message-ID: Subject: Re: [PATCH] net: fec: add support of ethtool get_regs From: Fabio Estevam To: Russell King - ARM Linux Cc: Philippe Reynes , "David S. Miller" , Duan Fugang-B38611 , Frank Li , =?UTF-8?Q?Lothar_Wa=C3=9Fmann?= , "netdev@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 19 Philippe, On Sat, May 9, 2015 at 6:17 PM, Russell King - ARM Linux wrote: > Using memcpy_fromio() to copy device registers is not a good idea - > it can use a variable access size which can cause bus faults. An example on how memcpy_fromio() can be avoided in get_regs: drivers/net/ethernet/samsung/sxgbe/sxgbe_ethtool.c Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/