Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752230AbbEJHxs (ORCPT ); Sun, 10 May 2015 03:53:48 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33260 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbbEJHxq (ORCPT ); Sun, 10 May 2015 03:53:46 -0400 Date: Sun, 10 May 2015 13:23:39 +0530 From: Sudip Mukherjee To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/33] staging: rtl8192e: Replace RTLLIB_DEBUG(DL_ERR) with netdev_*() Message-ID: <20150510075339.GB20096@sudip-PC> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-8-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431206361-13736-8-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 19 On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote: > Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err() > for errors that really should be reported to user. > Use netdev_warn() for the rest. > Rephrase some of the messages to make them more readable/compact. checkpatch is saying : CHECK: Alignment should match open parenthesis #332: FILE: drivers/staging/rtl8192e/rtl819x_TSProc.c:82: + netdev_warn(ieee->dev, + "%s(): Rx Reorder struct buffer full\n", regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/