Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbbEJKuH (ORCPT ); Sun, 10 May 2015 06:50:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54648 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750886AbbEJKuE (ORCPT ); Sun, 10 May 2015 06:50:04 -0400 Date: Sun, 10 May 2015 12:47:13 +0200 From: Maxime Ripard To: Vishnu Patekar Cc: emilio@elopez.com.ar, linus.walleij@linaro.org, robh+dt@kernel.org, hdegoede@redhat.com, wens@csie.org, jenskuske@gmail.com, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] ARM: dts: sun8i: Add ET-Q8 A33 support Message-ID: <20150510104713.GH11057@lukather> References: <1431240383-12763-1-git-send-email-vishnupatekar0510@gmail.com> <1431240383-12763-7-git-send-email-vishnupatekar0510@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wXC5D88JtmMokAwr" Content-Disposition: inline In-Reply-To: <1431240383-12763-7-git-send-email-vishnupatekar0510@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6438 Lines: 194 --wXC5D88JtmMokAwr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 10, 2015 at 12:16:23PM +0530, Vishnu Patekar wrote: > ET-Q8_A33 is A33 based cheap tablet in common Q8 format. >=20 > It has 512MB RAM, 4GB Nand, 7" Display, RDA5900P wifi, GSL1680 touch, etc. >=20 > Signed-off-by: VishnuPatekar > --- > arch/arm/boot/dts/Makefile | 3 +- > arch/arm/boot/dts/sun8i-a33-et-q8.dts | 108 ++++++++++++++++++++++++++++= ++++++ > 2 files changed, 110 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/sun8i-a33-et-q8.dts >=20 > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 82f4b9b..d44b1d6 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -570,7 +570,8 @@ dtb-$(CONFIG_MACH_SUN7I) +=3D \ > sun7i-a20-wexler-tab7200.dtb > dtb-$(CONFIG_MACH_SUN8I) +=3D \ > sun8i-a23-ippo-q8h-v5.dtb \ > - sun8i-a23-ippo-q8h-v1.2.dtb > + sun8i-a23-ippo-q8h-v1.2.dtb \ > + sun8i-a33-et-q8.dtb > dtb-$(CONFIG_MACH_SUN9I) +=3D \ > sun9i-a80-optimus.dtb \ > sun9i-a80-cubieboard4.dtb > diff --git a/arch/arm/boot/dts/sun8i-a33-et-q8.dts b/arch/arm/boot/dts/su= n8i-a33-et-q8.dts > new file mode 100644 > index 0000000..260d5a3 > --- /dev/null > +++ b/arch/arm/boot/dts/sun8i-a33-et-q8.dts > @@ -0,0 +1,108 @@ > +/* > + * Copyright 2015 Vishnu Patekar > + * Vishnu Patekar > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +/dts-v1/; > +#include "sun8i-a33.dtsi" > +#include "sunxi-common-regulators.dtsi" > + > +#include > +#include > +#include > + > +/ { > + model =3D "ET Q8 A33 "; There's one trailing space here. > + compatible =3D "et-q8-q33", "allwinner,sun8i", "allwinner,sun8i-a33"; All compatibles must be under the vendor,IP format. What is the maker of your board? That should also be in the DT name, under the format sun8i-a33-vendor-board.dts > + > + aliases { > + serial0 =3D &uart0; > + }; > + > + chosen { > + bootargs =3D "earlyprintk console=3DttyS0,115200"; > + }; Please use stdout-path here, just like we're doing on the other boards. > +}; > + > +&lradc { > + vref-supply =3D <®_vcc3v0>; > + status =3D "okay"; > + > + button@200 { > + label =3D "Volume Up"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <200000>; > + }; > + > + button@400 { > + label =3D "Volume Down"; > + linux,code =3D ; > + channel =3D <0>; > + voltage =3D <400000>; > + }; > +}; > + > +&i2c0 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c0_pins_a>; > + status =3D "okay"; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c1_pins_a>; > + status =3D "okay"; > +}; > + > +&i2c2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c2_pins_a>; > + /* pull-ups and devices require PMIC regulator */ > + status =3D "failed"; > +}; Is this still true, or is it just a copy/paste mistake? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --wXC5D88JtmMokAwr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVTzcwAAoJEBx+YmzsjxAgzgEP/iH1bIj1BZ5WsU9L0hVJiOA1 IMVyvNAJW2F+RH21Y2pNRubsw2QeBZXVcNjlVyWkY72FSEaYOwb8ZL9J8VloDvgB +BpE2pRY+GUcGc/bAJGszAPd15wf/r0CsvgtBjkc0vs9XUvMvrOQAlLynfaSbdBW st+HuE21NO1qq73rdUxwPcJ5XRfWfmzPb+PuCJkvyxAWI68CJthelcAnDM7F//U6 mn629Uhj7J+XQ0s0MElROPt927Y9s2He/VV5U1L97BdRZEGlM+9kq+DrYvi4Gsbs EVLjonpz9Bst1C7eM//Zy3qHboX0jRtsRi/Fn0rE3RZHKFtYCFbtdTydTr8g7wI1 3F18RJp5AJiP9o4pd1hVm6Y+wy/zvtvERUdlLtEKvqlDlb9uoLZfF7ffqE5K7qui 49J+kwAkQLntLXGui0481/MhxB/dHIMDRSq/rj6IWYiIcYDqgM7d0/8nGAl0c7Ug tuqxbwfc8CyppEctKZOFiU/JsekFrtqlEgzE17i26ye2Yyd1Z5+LYVB//X1iHIP1 4E3rnesp9Lv8QlR1JCCP4eoVfuIPipCEmeYTzLeTH3KSelJXSUOOq2Pldow5pikE WROR7tgB5YD2HlSR2rT9LjWv7hr81R51qAcq3W5Ehwu/fT9ql+jB/uyH+a2tZ6hs En6SVRwo9BVi4VNbt+Qp =60FP -----END PGP SIGNATURE----- --wXC5D88JtmMokAwr-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/