Date: Sun, 10 May 2015 15:14:43 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: German Rivera <German.Rivera@freescale.com>, devel@driverdev.osuosl.org,
        stuart.yoder@freescale.com, bhamciu1@freescale.com, arnd@arndb.de,
        bhupesh.sharma@freescale.com, linux-kernel@vger.kernel.org,
        agraf@suse.de, nir.erez@freescale.com, itai.katz@freescale.com,
        scottwood@freescale.com, R89243@freescale.com,
        richard.schmitt@freescale.com
Subject: Re: [PATCH v2 1/7] staging: fsl-mc: MC bus IRQ support
Message-ID: <20150510131443.GA4608@kroah.com>
References: <1430947708-10521-1-git-send-email-German.Rivera@freescale.com>
 <1430947708-10521-2-git-send-email-German.Rivera@freescale.com>
 <20150507130330.GI14154@mwanda>
 <554B7BF7.8030901@freescale.com>
 <20150507200118.GK14154@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150507200118.GK14154@mwanda>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1572
Lines: 33

On Thu, May 07, 2015 at 11:01:19PM +0300, Dan Carpenter wrote:
> On Thu, May 07, 2015 at 09:51:35AM -0500, German Rivera wrote:
> > I'll remove the nested #ifdef. However, as I explained before, these
> > #ifdefs are needed to be able to make the code compile without the
> > GIC-ITS support in place. Of course, the code will not be moved out
> > of staging with these #ifdefs. There is already an item for this in
> > the drivers/staging/fsl-mc/TODO file.
> 
> Heh.  This is a sort of amusing miscommunication.
> 
> I'm saying delete the dead code inside the ifdefs as well.  Obviously
> don't send code that can't compile.  :P  Btw, it's really easy to
> commit parts of a file in git citool.  Just highlight, right click and
> select "add lines to commit".
> 
> Although if Greg wants to allow these ifdefs in, then my feelings will
> not be hurt and I am fine with that.

Nope, in fact, I don't want to see any new code added here for this
subsystem that isn't "correct".  Just because the code is in staging
doesn't mean you get to add stuff that doesn't follow the rest of the
kernel's normal rules.

I want to see the existing code fixed up and moved _out_ of staging
first, before adding a bunch of new stuff here.  Please don't just add
to the TODO list, like you are doing with this series, that's not ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/