Message-ID: <1431288982.29257.31.camel@perches.com>
Subject: Re: [PATCH 2/2] vsprintf: Add support for userspace strings
From: Joe Perches <joe@perches.com>
To: Richard Weinberger <richard@nod.at>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Date: Sun, 10 May 2015 13:16:22 -0700
In-Reply-To: <554FBB8F.3070204@nod.at>
References: <1431286936-4333-1-git-send-email-richard@nod.at>
	 <1431286936-4333-3-git-send-email-richard@nod.at>
	 <1431288580.29257.29.camel@perches.com> <554FBB8F.3070204@nod.at>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 801
Lines: 25

On Sun, 2015-05-10 at 22:11 +0200, Richard Weinberger wrote:
> Am 10.05.2015 um 22:09 schrieb Joe Perches:
> > On Sun, 2015-05-10 at 21:42 +0200, Richard Weinberger wrote:
> >> Add %pL format string to print userspace strings.
> >> It works like %s but does copy_from_user() instead
> >> of a memcpy().
> > 
> > I think this would be much simpler in a new
> > function rather than complicating string()
> 
> -ENOPATCH.

It's your patch, I'm just commenting on it.

I'm not sure there's much value in it.

Can it can add security holes if used with %pV?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/