Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbbEKDai (ORCPT ); Sun, 10 May 2015 23:30:38 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:43363 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbEKDag (ORCPT ); Sun, 10 May 2015 23:30:36 -0400 Date: Mon, 11 May 2015 12:30:33 +0900 Message-ID: <873833x02u.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Richard Weinberger Cc: LKML , Linux-Arch Subject: Re: [PATCH v11 06/19] h8300: Assembly headers In-Reply-To: References: <1431097479-21101-1-git-send-email-ysato@users.sourceforge.jp> <1431097479-21101-7-git-send-email-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 6645 Lines: 164 At Sun, 10 May 2015 12:46:14 +0200, Richard Weinberger wrote: > > On Fri, May 8, 2015 at 5:04 PM, Yoshinori Sato > wrote: > > Signed-off-by: Yoshinori Sato > > diff --git a/arch/h8300/include/asm/uaccess.h b/arch/h8300/include/asm/uaccess.h > > new file mode 100644 > > index 0000000..582af79 > > --- /dev/null > > +++ b/arch/h8300/include/asm/uaccess.h > > @@ -0,0 +1,131 @@ > > +#ifndef __H8300_UACCESS_H > > +#define __H8300_UACCESS_H > > + > > +/* > > + * User space memory access functions > > + */ > > +#include > > +#include > > +#include > > + > > +#include > > + > > +#define VERIFY_READ 0 > > +#define VERIFY_WRITE 1 > > + > > +/* We let the MMU do all checking */ > > +#define access_ok(type, addr, size) __access_ok((unsigned long)addr, size) > > +static inline int __access_ok(unsigned long addr, unsigned long size) > > +{ > > + return 1; > > +} > > + > > +/* > > + * The exception table consists of pairs of addresses: the first is the > > + * address of an instruction that is allowed to fault, and the second is > > + * the address at which the program should continue. No registers are > > + * modified, so it is entirely up to the continuation code to figure out > > + * what to do. > > + * > > + * All the routines below use bits of fixup code that are out of line > > + * with the main instruction path. This means when everything is well, > > + * we don't even have to jump over them. Further, they do not intrude > > + * on our cache or tlb entries. > > + */ > > + > > +struct exception_table_entry { > > + unsigned long insn, fixup; > > +}; > > + > > +/* Returns 0 if exception not found and fixup otherwise. */ > > +extern unsigned long search_exception_table(unsigned long); > > + > > + > > +/* > > + * These are the main single-value transfer routines. They automatically > > + * use the right size if we just have the right pointer type. > > + */ > > + > > +#define put_user(x, ptr) \ > > +({ \ > > + int __pu_err = 0; \ > > + typeof(*(ptr)) __pu_val = (x); \ > > + switch (sizeof(*(ptr))) { \ > > + case 1: \ > > + /* falll through */ \ > > + case 2: \ > > + /* fall through */ \ > > + case 4: \ > > + *(ptr) = x; \ > > + break; \ > > + case 8: \ > > + memcpy(ptr, &__pu_val, sizeof(*(ptr))); \ > > + break; \ > > + default: \ > > + __pu_err = __put_user_bad(); \ > > + break; \ > > + } \ > > + __pu_err; \ > > +}) > > + > > +#define __put_user(x, ptr) put_user(x, ptr) > > + > > +extern int __put_user_bad(void); > > + > > +/* > > + * Tell gcc we read from memory instead of writing: this is because > > + * we do not write to any memory gcc knows about, so there are no > > + * aliasing issues. > > + */ > > + > > +#define __ptr(x) ((unsigned long *)(x)) > > + > > +/* > > + * Tell gcc we read from memory instead of writing: this is because > > + * we do not write to any memory gcc knows about, so there are no > > + * aliasing issues. > > + */ > > + > > +#define get_user(x, ptr) \ > > +({ \ > > + typeof(*(ptr)) __gu_val; \ > > + int __gu_err = 0; \ > > + switch (sizeof(*(ptr))) { \ > > + case 1: \ > > + *(u8 *)&__gu_val = *((u8 *)(ptr)); \ > > + break; \ > > + case 2: \ > > + *(u16 *)&__gu_val = *((u16 *)ptr); \ > > + break; \ > > + case 4: \ > > + *(u32 *)&__gu_val = *((u32 *)ptr); \ > > + break; \ > > + case 8: \ > > + memcpy((void *)&__gu_val, ptr, sizeof(*(ptr))); \ > > + break; \ > > + default: \ > > + __gu_err = __get_user_bad(); \ > > + break; \ > > + } \ > > + (x) = (typeof(*(ptr)))__gu_val; \ > > + __gu_err; \ > > +}) > > +#define __get_user(x, ptr) get_user(x, ptr) > > + > > +extern int __get_user_bad(void); > > + > > +#define copy_from_user(to, from, n) (memcpy(to, from, n), 0) > > +#define copy_to_user(to, from, n) (memcpy(to, from, n), 0) > > + > > +#define __copy_from_user(to, from, n) copy_from_user(to, from, n) > > +#define __copy_to_user(to, from, n) copy_to_user(to, from, n) > > +#define __copy_to_user_inatomic __copy_to_user > > +#define __copy_from_user_inatomic __copy_from_user > > + > > +unsigned long clear_user(void __user *addr, unsigned long size); > > +#define strnlen_user(s, n) (strnlen(s, n) + 1) > > +long strncpy_from_user(char *d, const char *s, long n); > > + > > +#define __clear_user clear_user > > + > > +#endif /* _H8300_UACCESS_H */ > > Nothing serious, but I think you can drop most code in this file by > using asm-generic/uaccess.h. Yes. Can use generic version. I'll update next release > -- > Thanks, > //richard Thanks. -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/