From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
To: Alan Stern <stern@rowland.harvard.edu>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@ti.com" <balbi@ti.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
 EHCI drv
Thread-Topic: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
 EHCI drv
Thread-Index: AQHQiMJfIXxmm4goP0yRszanEkdHF51wl5SAgADuGhCAAJ6mAIAEHW5w
Date: Mon, 11 May 2015 05:18:08 +0000
Message-ID: <SN1PR0301MB1583F2DB22E8D5FAD2303F6EE0DB0@SN1PR0301MB1583.namprd03.prod.outlook.com>
References: <SN1PR0301MB1583E7B2CFB5044E9850DFD9E0DE0@SN1PR0301MB1583.namprd03.prod.outlook.com>
 <Pine.LNX.4.44L0.1505081021560.1219-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1505081021560.1219-100000@iolanthe.rowland.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2015 05:18:08.9079
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1584
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2156
Lines: 52


> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: Friday, May 08, 2015 7:56 PM
> To: Mehresh Ramneek-B31383
> Cc: linux-kernel@vger.kernel.org; balbi@ti.com; linux-usb@vger.kernel.org;
> gregkh@linuxfoundation.org
> Subject: RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
> EHCI drv
> 
> On Fri, 8 May 2015, Ramneek Mehresh wrote:
> 
> > > On Thu, 7 May 2015, Ramneek Mehresh wrote:
> > >
> > > > Make use of ehci_driver_overrides structure for ehci-fsl driver
> > > >
> > > > Signed-off-by: Ramneek Mehresh
> <ramneek.mehresh@freescale.com>
> > >
> > > You need to change a lot more than this.  See commit a76dd463c58e
> (USB:
> > > EHCI: make ehci-orion a separate driver) as an example of what is
> > > needed.  In the end, ehci-fsl.ko should be a new driver module, not
> > > compiled into ehci- hcd.ko.
> > >
> > I can definitely make this change, but this patch set is about OTG
> > functionality fix for all FSL QorIQ socs. Changes you are asking are
> > for FSL Host driver. For that I can float separate patch/patch set.
> > Hence, I would request you to please accept the Patch series in conext
> > of OTG functionality fix
> 
> Accept which patch series?  You have posted several different versions (and
> you failed to put the version numbers in the email Subject:
> lines, so I can't tell which patches belong to which version!).
> 
> I am not going to accept something that does a partial job of converting ehci-
> fsl into a separate module.  Either do the entire conversion first, as a
> separate patch that is prerequisite to the OTG fix, or else fix the OTG stuff in
> a way that doesn't require ehci-fsl to be a separate module.
> 
Ok, then let me first fix USB host driver as per expectation...
I'll then re-send OTG patch set over that...I don't want to intermingle these two
separate functionalities. Thanks.

> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/