Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbbEKGAn (ORCPT ); Mon, 11 May 2015 02:00:43 -0400 Received: from www.osadl.org ([62.245.132.105]:34755 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbbEKGAi (ORCPT ); Mon, 11 May 2015 02:00:38 -0400 From: Nicholas Mc Guire To: Josh Poimboeuf Cc: Seth Jennings , Jiri Kosina , Vojtech Pavlik , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] livepatch: match return value to function signature Date: Mon, 11 May 2015 07:52:29 +0200 Message-Id: <1431323549-27343-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 40 klp_initialized() should return bool but is actually returning struct kobject * - convert it to a boolean explicitly. Signed-off-by: Nicholas Mc Guire --- static code checking was not happy with ./kernel/livepatch/core.c:131 WARNING: return of wrong type bool != struct kobject * This adds !! to explicitly convert to boolean type. Patch was compile tested with x86_64_defconfig patch is against 4.1-rc2 (localversion-next is -next-20150508) kernel/livepatch/core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 0e7c23c..c0ae3d8 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -128,7 +128,7 @@ static bool klp_is_patch_registered(struct klp_patch *patch) static bool klp_initialized(void) { - return klp_root_kobj; + return !!klp_root_kobj; } struct klp_find_arg { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/