Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbbEKHW1 (ORCPT ); Mon, 11 May 2015 03:22:27 -0400 Received: from lb3-smtp-cloud3.xs4all.net ([194.109.24.30]:33539 "EHLO lb3-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbEKHWZ (ORCPT ); Mon, 11 May 2015 03:22:25 -0400 Message-ID: <1431328936.2398.67.camel@x220> Subject: Re: [PATCH 2/6] pinctrl: sunxi: add allwinner A33 PIO controller support From: Paul Bolle To: Vishnu Patekar Cc: maxime.ripard@free-electrons.com, emilio@elopez.com.ar, linus.walleij@linaro.org, robh+dt@kernel.org, hdegoede@redhat.com, wens@csie.org, jenskuske@gmail.com, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org Date: Mon, 11 May 2015 09:22:16 +0200 In-Reply-To: <1431240383-12763-3-git-send-email-vishnupatekar0510@gmail.com> References: <1431240383-12763-1-git-send-email-vishnupatekar0510@gmail.com> <1431240383-12763-3-git-send-email-vishnupatekar0510@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 59 On Sun, 2015-05-10 at 12:16 +0530, Vishnu Patekar wrote: > --- a/drivers/pinctrl/sunxi/Kconfig > +++ b/drivers/pinctrl/sunxi/Kconfig > + (Unneeded white line.) > +config PINCTRL_SUN8I_A33 > + def_bool MACH_SUN8I > + select PINCTRL_SUNXI_COMMON > --- a/drivers/pinctrl/sunxi/Makefile > +++ b/drivers/pinctrl/sunxi/Makefile > +obj-$(CONFIG_PINCTRL_SUN8I_A33) += pinctrl-sun8i-a33.o PINCTRL_SUN8I_A33 is a bool symbol, so pinctrl-sun8i-a33.o will never be part of a module, right? > --- /dev/null > +++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-a33.c > @@ -0,0 +1,513 @@ > +#include > +MODULE_DEVICE_TABLE(of, sun8i_a33_pinctrl_match); > + > +static struct platform_driver sun8i_a33_pinctrl_driver = { > + .probe = sun8i_a33_pinctrl_probe, > + .driver = { > + .name = "sun8i-a33-pinctrl", > + .of_match_table = sun8i_a33_pinctrl_match, > + }, > +}; > +module_platform_driver(sun8i_a33_pinctrl_driver); (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow to use builtin_platform_driver() for built-in only code.) > +MODULE_AUTHOR("Vishnu Patekar "); > +MODULE_DESCRIPTION("Allwinner a33 pinctrl driver"); > +MODULE_LICENSE("GPL"); This adds some module specific boilerplate. Was it perhaps your intention to make PINCTRL_SUN8I_A33 a tristate symbol? If I understand Maxime correctly drivers like these can be made modular (see https://lkml.org/lkml/2015/5/9/96 ). Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/