Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbEKH1l (ORCPT ); Mon, 11 May 2015 03:27:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:49907 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbbEKH1k (ORCPT ); Mon, 11 May 2015 03:27:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,405,1427785200"; d="scan'208";a="491940731" Message-ID: <1431329256.28073.40.camel@linux.intel.com> Subject: Re: [PATCH 0/2] x86/earlyprintk: setup earlyprintk as early as possible From: Andy Shevchenko To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Date: Mon, 11 May 2015 10:27:36 +0300 In-Reply-To: <1431285225-5666-1-git-send-email-kuleshovmail@gmail.com> References: <1431285225-5666-1-git-send-email-kuleshovmail@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1746 Lines: 44 On Mon, 2015-05-11 at 01:13 +0600, Alexander Kuleshov wrote: > As setup_early_printk passed to the early_param, it will be usable only after > 'parse_early_param' function will be called from the 'setup_arch'. So we have > earlyprintk during early boot and decompression. Next point after decompression > of the kernel where we can use early_printk is after call of the > 'parse_early_param'. >From this description is hard to understand what is rationale of the proposed changes. Can you rephrase it? > > These patchset provides two patches where: > > 1. Move handling of the builtin command line to the separate function > from the setup_arch. Now we can call it from the arch/x86/kernel/head{32,64}.c, > and find 'earlyprintk' kernel command line paramter there. > > 2. Provide setup_serial_console function to setup serial earlyprintk in the > arch/x86/kernel/head{32,64}.c > > Alexander Kuleshov (2): > x86/setup: update boot_command_line with builtin_cmdline in separate > function > x86/earlyprintk: setup earlyprintk as early as possible > > arch/x86/include/asm/serial.h | 2 ++ > arch/x86/include/asm/setup.h | 3 ++- > arch/x86/kernel/early_printk.c | 25 +++++++++++++++++++++++++ > arch/x86/kernel/head32.c | 6 ++++++ > arch/x86/kernel/head64.c | 7 +++++++ > arch/x86/kernel/setup.c | 28 +++++++++++++++------------- > 6 files changed, 57 insertions(+), 14 deletions(-) > -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/