Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbbEKHbL (ORCPT ); Mon, 11 May 2015 03:31:11 -0400 Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:60488 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468AbbEKHbH (ORCPT ); Mon, 11 May 2015 03:31:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AoCQBxWVBVPPDOLHlcgw+BMoZMrCMBAQEBAQEGkXUJh1cCAgEBAoEhORQBAQEBAQEBBgEBAQFBP4QhAQEEOhwjEAgDGAklDwUlAwcaE4grxwcBAQgCAR8YhX6FI4UFB4QtBZ0fjGmJb4EEgygsMYJGAQEB Date: Mon, 11 May 2015 17:31:04 +1000 From: Dave Chinner To: Trond Myklebust Cc: Sage Weil , Zach Brown , Alexander Viro , Linux FS-devel Mailing List , Linux Kernel Mailing List , Linux API Mailing List Subject: Re: [PATCH RFC] vfs: add a O_NOMTIME flag Message-ID: <20150511073103.GO4327@dastard> References: <1430949612-21356-1-git-send-email-zab@redhat.com> <20150507002617.GJ4327@dastard> <20150507172053.GA659@lenny.home.zabbo.net> <20150508221325.GM4327@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 29 On Sun, May 10, 2015 at 07:13:24PM -0400, Trond Myklebust wrote: > On Fri, May 8, 2015 at 6:24 PM, Sage Weil wrote: > > I'm sure you realize what we're try to achieve is the same "invisible IO" > > that the XFS open by handle ioctls do by default. Would you be more > > comfortable if this option where only available to the generic > > open_by_handle syscall, and not to open(2)? > > It should be an ioctl(). It has no business being part of > open_by_handle either, since that is another generic interface. I'm happy for it to be an ioctl interface - even an XFS specific interface if you want to go that route, Sage - and it probably should emit a warning to syslog first time it is used so there is trace for bug triage purposes. i.e. we know the app is not using mtime updates, so bug reports that are the result of mtime mishandling don't result in large amounts of wasted developer time trying to understand them... Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/