Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936AbbEKI07 (ORCPT ); Mon, 11 May 2015 04:26:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20302 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbEKI04 (ORCPT ); Mon, 11 May 2015 04:26:56 -0400 Date: Mon, 11 May 2015 11:26:47 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy() Message-ID: <20150511082646.GI14154@mwanda> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-4-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431206361-13736-4-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 33 On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_rx.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > index ebb328d..65e4d13 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -488,15 +488,19 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, struct rtllib_rxb **prx > * and replace EtherType > */ > skb_pull(sub_skb, SNAP_SIZE); > - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, ETH_ALEN); > - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->dst, ETH_ALEN); > + memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, > + ETH_ALEN); /* Must be unaligned */ Which part isn't aligned? I think they both are. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/