Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbbEKJAX (ORCPT ); Mon, 11 May 2015 05:00:23 -0400 Received: from www.osadl.org ([62.245.132.105]:35856 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbbEKJAS (ORCPT ); Mon, 11 May 2015 05:00:18 -0400 From: Nicholas Mc Guire To: "Paul E. McKenney" Cc: Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] rcu: change function declaration to bool Date: Mon, 11 May 2015 10:51:55 +0200 Message-Id: <1431334315-7002-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 43 rcu_cpu_has_callbacks() is declared int but is actually returning bool and all call-sites currently use it as bool so the declaration should be bool as well. Signed-off-by: Nicholas Mc Guire --- ./kernel/rcu/tree.c:3538 WARNING: return of wrong type int != bool, as the description of rcu_cpu_has_callbacks() states: " * Return true if the specified CPU has any callback...." this probably should be a bool All (3) call sites are conditions and are treating it as boolean. Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) Patch is against 4.1-rc3 (localversion-next is -next-20150511) kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index bcc5943..599550c 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3516,7 +3516,7 @@ static int rcu_pending(void) * non-NULL, store an indication of whether all callbacks are lazy. * (If there are no callbacks, all of them are deemed to be lazy.) */ -static int __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy) +static bool __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy) { bool al = true; bool hc = false; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/