Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbbEKIx4 (ORCPT ); Mon, 11 May 2015 04:53:56 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36976 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbEKIxz (ORCPT ); Mon, 11 May 2015 04:53:55 -0400 MIME-Version: 1.0 In-Reply-To: <20150510101750.GC11057@lukather> References: <1431240383-12763-1-git-send-email-vishnupatekar0510@gmail.com> <1431240383-12763-4-git-send-email-vishnupatekar0510@gmail.com> <20150510101750.GC11057@lukather> Date: Mon, 11 May 2015 14:23:54 +0530 Message-ID: Subject: Re: [PATCH 3/6] clk: sunxi: Add A33 clock for compilation From: Vishnu Patekar To: Maxime Ripard Cc: emilio@elopez.com.ar, Linus Walleij , "robh+dt@kernel.org" , Hans de Goede , Chen-Yu Tsai , Jens Kuske , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-sunxi@googlegroups.com" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 38 Hi, On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard wrote: > Hi, > > On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote: >> A33 clock control unit is similar to A23. >> >> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE >> to get it compiled for A33. > > That commit log doesn't make any sense. > > What you're doing isn't about whether or not that will be compiled, > but whether you're registering the clocks and which clocks you > protect. Actually, It's just registering the a33 clocks and reusing a23 code. nothing to do with compile. I'll correct it in next patch version. > >> Signed-off-by: VishnuPatekar > > Isn't it supposed to have a space in the middle of your name, just > like you have in your mail address? Yes, There should be space. > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/