Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbbEKJb2 (ORCPT ); Mon, 11 May 2015 05:31:28 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:32935 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbbEKJb1 (ORCPT ); Mon, 11 May 2015 05:31:27 -0400 Date: Mon, 11 May 2015 11:31:22 +0200 From: Ingo Molnar To: He Kuang Cc: masami.hiramatsu.pt@hitachi.com, a.p.zijlstra@chello.nl, acme@kernel.org, jolsa@kernel.org, mingo@redhat.com, wangnan0@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] perf probe: Show better error message when failed to find variable Message-ID: <20150511093122.GB31869@gmail.com> References: <1431336304-16863-1-git-send-email-hekuang@huawei.com> <1431336304-16863-3-git-send-email-hekuang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431336304-16863-3-git-send-email-hekuang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 24 * He Kuang wrote: > Indicate to check variable location range in error message when we got > failed to find the variable. > > Before this patch: > > $ perf probe --add 'generic_perform_write+118 bytes' > Failed to find the location of bytes at this address. > Perhaps, it has been optimized out. > Error: Failed to add events. Btw., you talk about 'variables', but generic_perform_write() is a function name? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/