Date: Mon, 11 May 2015 11:50:52 +0200
From: Ingo Molnar <mingo@kernel.org>
To: He Kuang <hekuang@huawei.com>
Cc: masami.hiramatsu.pt@hitachi.com, a.p.zijlstra@chello.nl, acme@kernel.org,
        jolsa@kernel.org, mingo@redhat.com, wangnan0@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] perf probe: Show better error message when failed
 to find variable
Message-ID: <20150511095052.GA7441@gmail.com>
References: <1431336304-16863-1-git-send-email-hekuang@huawei.com>
 <1431336304-16863-3-git-send-email-hekuang@huawei.com>
 <20150511093010.GA31869@gmail.com>
 <555079CF.40701@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <555079CF.40701@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1609
Lines: 49


* He Kuang <hekuang@huawei.com> wrote:

> Hi, Ingo
> 
> On 2015/5/11 17:30, Ingo Molnar wrote:
> >* He Kuang <hekuang@huawei.com> wrote:
> >
> >>Indicate to check variable location range in error message when we got
> >>failed to find the variable.
> >>
> >>Before this patch:
> >>
> >>   $ perf probe --add 'generic_perform_write+118 bytes'
> >>   Failed to find the location of bytes at this address.
> >>    Perhaps, it has been optimized out.
> >>     Error: Failed to add events.
> >>
> >>After this patch:
> >>   $ perf probe --add 'generic_perform_write+118 bytes'
> >>   Failed to find the location of bytes at this address.
> >What does this sentence mean? I thought 'address' means 'location of
> >bytes'. So the address identifies the location and obviously we know
> >that. So this message wants to say something else.
> 
> 'generic_perform_write' is a function name, while 'bytes' is a local
> variable in this function. Maybe the variable I chose make you confused.
> 
> This maybe clear:
>   Failed to find the location of 'bytes' at this address.

Yeah, absolutely! This highlights the importance of putting 
user-supplied symbols into quotes and such.

Maybe even write:

    Failed to find the location of the 'bytes' variable at this address.

Another question: what does 'generic_perform_write+118' mean here? Why 
the offset?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/