Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbbEKLyN (ORCPT ); Mon, 11 May 2015 07:54:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:11851 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbbEKLyK convert rfc822-to-8bit (ORCPT ); Mon, 11 May 2015 07:54:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,406,1427785200"; d="scan'208";a="492019447" From: "Drokin, Oleg" To: Sudip Mukherjee CC: Dan Carpenter , "Dilger, Andreas" , Greg Kroah-Hartman , "" , "" , "" Subject: Re: [PATCH] staging: lustre: remove unused variable Thread-Topic: [PATCH] staging: lustre: remove unused variable Thread-Index: AQHQi9fhQUJ6mze6j0e1enz19QBRA513GZQAgAADl4CAAALQgA== Date: Mon, 11 May 2015 11:53:57 +0000 Message-ID: <6D1AC27D-38EB-42FE-8895-A0641F614C83@intel.com> References: <1431341230-29639-1-git-send-email-sudipm.mukherjee@gmail.com> <20150511113102.GK14154@mwanda> <20150511114330.GA11994@sudip-PC> In-Reply-To: <20150511114330.GA11994@sudip-PC> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.22.139] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 39 Hello! On May 11, 2015, at 7:43 AM, Sudip Mukherjee wrote: > On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote: >> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote: >>> - if (set->set_pga) { >>> - int len = set->set_oabufs * sizeof(*set->set_pga); >>> + if (set->set_pga) >>> OBD_FREE_LARGE(set->set_pga, len); >> ^^^ >> It's used right here? > > oops.. sorry .. but why i didnot get a build failure after this? > > ok, got it ... > > #define OBD_FREE_LARGE(ptr, size) \ > do { \ > kvfree(ptr); \ > } while (0) > > the variable is actually not used. I will make a v2 and send > tomorrow. today is a day of silly mistakes :( It's probably best to wait for a bit at this point. Julia is going to send in a bunch of patches actually getting rid of those macros. And then whatever stuff surfaces would be easier to see. Thanks! Bye, Oleg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/