Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbbEKNJK (ORCPT ); Mon, 11 May 2015 09:09:10 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56801 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753909AbbEKNJH (ORCPT ); Mon, 11 May 2015 09:09:07 -0400 Date: Mon, 11 May 2015 06:09:01 -0700 From: Guenter Roeck To: Michael Brunner Cc: linux-kernel@vger.kernel.org, Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, Jochen Henneberg , Michael Brunner , Darren Hart , Kevin Strasser Subject: Re: [PATCH] gpio: gpio-kempld: Fix get_direction return value Message-ID: <20150511130901.GB24321@roeck-us.net> References: <20150511124649.1221e86e@hyperion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150511124649.1221e86e@hyperion> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.5550A9F3.004E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 20 On Mon, May 11, 2015 at 12:46:49PM +0200, Michael Brunner wrote: > This patch fixes an inverted return value of the gpio get_direction > function. > > The wrong value causes the direction sysfs entry and GPIO debugfs file > to indicate incorrect GPIO direction settings. In some cases it also > prevents setting GPIO output values. > > The problem is also present in all other stable kernel versions since > linux-3.12. > > Reported-by: Jochen Henneberg > Signed-off-by: Michael Brunner Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/