Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754080AbbEKNXB (ORCPT ); Mon, 11 May 2015 09:23:01 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:30191 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbbEKNXA (ORCPT ); Mon, 11 May 2015 09:23:00 -0400 Date: Mon, 11 May 2015 16:22:46 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max Message-ID: <20150511132246.GL14154@mwanda> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-29-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431206361-13736-29-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 34 On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: > Warninig is printed if precision is lost - it can't happen at moment as > all get_key implementations return either -1 or small buffers. > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtllib_wx.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c > index 2ac1617..22bea5a 100644 > --- a/drivers/staging/rtl8192e/rtllib_wx.c > +++ b/drivers/staging/rtl8192e/rtllib_wx.c > @@ -510,7 +510,10 @@ int rtllib_wx_get_encode(struct rtllib_device *ieee, > return 0; > } > len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv); > - erq->length = (len >= 0 ? len : 0); > + if (len > U16_MAX) > + netdev_err(ieee->dev, "Too long key returned.\n"); Just delete the check if it can't happen or handle the error properly. Never printed messages can be annoying. Static checkers assume all conditions can happen so never true conditions are confusing. It wastes RAM. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/