Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbbEKNYv (ORCPT ); Mon, 11 May 2015 09:24:51 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:36564 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbbEKNYt (ORCPT ); Mon, 11 May 2015 09:24:49 -0400 MIME-Version: 1.0 In-Reply-To: <87vbfzjt4t.fsf@kamboji.qca.qualcomm.com> References: <20150505224020.GA3805@bytefire-computer> <87wq0ms3mv.fsf@kamboji.qca.qualcomm.com> <20150506063241.GA3042@bytefire-computer> <87k2wflj7p.fsf@kamboji.qca.qualcomm.com> <2CBE2DDF-92E5-45C9-95F8-C5CF918D12D9@gmail.com> <87vbfzjt4t.fsf@kamboji.qca.qualcomm.com> From: Jonas Gorski Date: Mon, 11 May 2015 15:24:18 +0200 Message-ID: Subject: Re: [PATCH 2/2] adm8211: fix the possible pci cache line sizes inside switch-case To: Kalle Valo Cc: Okash Khawaja , "joe@perches.com" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 23 Hi, On Mon, May 11, 2015 at 12:38 PM, Kalle Valo wrote: > Okash Khawaja writes: > >> Sure, I'll create v2 of the patch with updated commit log. >> >> Since it's part of a patch set, do you want me to send both the >> patches in the patch set together as v2 or just this patch? > > Please resend the whole patchset as v2, less problems that way. If you are sending a v2 anyway, I'd suggest using decimal values for the cases, as cache line sizes are usually given in decimal anyway. So just drop the "0x" instead of converting the values ;-) Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/