Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754414AbbEKNsx (ORCPT ); Mon, 11 May 2015 09:48:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50465 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754387AbbEKNsu (ORCPT ); Mon, 11 May 2015 09:48:50 -0400 Date: Mon, 11 May 2015 16:48:40 +0300 From: Dan Carpenter To: Mateusz Kulikowski Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param() Message-ID: <20150511134840.GM14154@mwanda> References: <1431206361-13736-1-git-send-email-mateusz.kulikowski@gmail.com> <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431206361-13736-5-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 25 On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote: > + if (info_element->len >= 4 && > + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 && > + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) { This if statement was actually easier to read in the original code: if (info_element->len >= 4 && info_element->data[0] == 0x00 && info_element->data[1] == 0x50 && info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) { Your eye can immediately spot the bits which are different on each line when they are lined up like that. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/