Date: Mon, 11 May 2015 11:28:30 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <laijs@cn.fujitsu.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] rcu: change function declaration to bool
Message-ID: <20150511112830.275b2c02@gandalf.local.home>
In-Reply-To: <1431357059-29795-1-git-send-email-hofrat@osadl.org>
References: <1431357059-29795-1-git-send-email-hofrat@osadl.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2092
Lines: 56

On Mon, 11 May 2015 17:10:59 +0200
Nicholas Mc Guire <hofrat@osadl.org> wrote:

> rcu_cpu_has_callbacks() is declared int but is actually returning bool and
> and as the function description states " * Return true if the specified 
> CPU has any callback....", this probably should be a bool. All (3) 
> call-sites currently treat it as bool so the declaration.
> 
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> V2: fixed up commit message and tool infos as requested by 
>     Josh Triplett <josh@joshtriplett.org>
> 
> Type-checking coccinelle spatches are being used to locate type 
> mismatches between function signatures and return values. 
> ./kernel/rcu/tree.c:3538 WARNING: return of wrong type
>                     int != bool, 
> 
> Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y)
> 
> Patch is against 4.1-rc3 (localversion-next is -next-20150511)

I think what Josh was saying is that all the above except for the "V2"
should be above the signature. Everything between the "---" and the
patch gets tossed out when committed into git.

Giving credit to coccinelle and even what branch and config was used
for testing is something we want in the git change log history.

-- Steve

> 
>  kernel/rcu/tree.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index bcc5943..599550c 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3516,7 +3516,7 @@ static int rcu_pending(void)
>   * non-NULL, store an indication of whether all callbacks are lazy.
>   * (If there are no callbacks, all of them are deemed to be lazy.)
>   */
> -static int __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
> +static bool __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy)
>  {
>  	bool al = true;
>  	bool hc = false;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/