Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbbEKPbQ (ORCPT ); Mon, 11 May 2015 11:31:16 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33692 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbbEKPbO (ORCPT ); Mon, 11 May 2015 11:31:14 -0400 MIME-Version: 1.0 In-Reply-To: <1431357666-6808-1-git-send-email-niklass@axis.com> References: <1431357666-6808-1-git-send-email-niklass@axis.com> Date: Mon, 11 May 2015 12:31:12 -0300 Message-ID: Subject: Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe From: Fabio Estevam To: Niklas Cassel Cc: Florian Fainelli , "David S. Miller" , "netdev@vger.kernel.org" , linux-kernel , johan@kernel.org, Niklas Cassel , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 24 On Mon, May 11, 2015 at 12:21 PM, Niklas Cassel wrote: > Don't do clock-mode-select if clk == NULL, > since when building without CONFIG_HAVE_CLK, > clk_get returns NULL and clk_get_rate returns 0. > > Doing clock-mode-select in this cause causes kszphy_probe to > return -EINVAL and thus prevents the device from being probed. > > The original code (before regression) would return 0 > when building without CONFIG_HAVE_CLK. > > Cc: stable # 3.18+ > 1fadee0c3645 ("net/phy: micrel: Add clock support for > KSZ8021/KSZ8031") > Signed-off-by: Niklas Cassel Looks good now: Reviewed-by: Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/