Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753667AbbEKPiN (ORCPT ); Mon, 11 May 2015 11:38:13 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:53535 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbbEKPiK (ORCPT ); Mon, 11 May 2015 11:38:10 -0400 X-Originating-IP: 50.43.43.179 Date: Mon, 11 May 2015 08:37:31 -0700 From: Josh Triplett To: Steven Rostedt Cc: Nicholas Mc Guire , "Paul E. McKenney" , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] rcu: change function declaration to bool Message-ID: <20150511153731.GA831@x> References: <1431357059-29795-1-git-send-email-hofrat@osadl.org> <20150511112830.275b2c02@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150511112830.275b2c02@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 40 On Mon, May 11, 2015 at 11:28:30AM -0400, Steven Rostedt wrote: > On Mon, 11 May 2015 17:10:59 +0200 > Nicholas Mc Guire wrote: > > > rcu_cpu_has_callbacks() is declared int but is actually returning bool and > > and as the function description states " * Return true if the specified > > CPU has any callback....", this probably should be a bool. All (3) > > call-sites currently treat it as bool so the declaration. > > > > > > Signed-off-by: Nicholas Mc Guire > > --- > > > > V2: fixed up commit message and tool infos as requested by > > Josh Triplett > > > > Type-checking coccinelle spatches are being used to locate type > > mismatches between function signatures and return values. > > ./kernel/rcu/tree.c:3538 WARNING: return of wrong type > > int != bool, > > > > Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) > > > > Patch is against 4.1-rc3 (localversion-next is -next-20150511) > > I think what Josh was saying is that all the above except for the "V2" > should be above the signature. Everything between the "---" and the > patch gets tossed out when committed into git. > > Giving credit to coccinelle and even what branch and config was used > for testing is something we want in the git change log history. Yes, exactly. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/