Date: Mon, 11 May 2015 17:38:22 +0200
From: Johan Hovold <johan@kernel.org>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: f.fainelli@gmail.com, festevam@gmail.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org, johan@kernel.org,
        Niklas Cassel <niklass@axis.com>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe
Message-ID: <20150511153822.GA27224@localhost>
References: <1431357666-6808-1-git-send-email-niklass@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431357666-6808-1-git-send-email-niklass@axis.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1082
Lines: 32

On Mon, May 11, 2015 at 05:21:06PM +0200, Niklas Cassel wrote:
> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
> 
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
> 
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
> 
> Cc: stable <stable@vger.kernel.org> # 3.18+
> 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")

Looks like you forgot the "Fixes: " tag itself when updating.

> Signed-off-by: Niklas Cassel <niklass@axis.com>

Look good otherwise, feel free to add my

Reviewed-by: Johan Hovold <johan@kernel.org>

when resending (unless David wants to fix it up himself).

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/