Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673AbbEKQAP (ORCPT ); Mon, 11 May 2015 12:00:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48451 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbbEKQAN (ORCPT ); Mon, 11 May 2015 12:00:13 -0400 Date: Mon, 11 May 2015 12:59:58 -0300 From: "acme@redhat.com" To: Ingo Molnar Cc: Will Deacon , David Ahern , "linux-kernel@vger.kernel.org" , Mark Rutland , "jolsa@kernel.org" , "namhyung@kernel.org" Subject: Re: arm/arm64 perf build issue with mainline Message-ID: <20150511155958.GB2724@redhat.com> References: <20150423112916.GF1652@arm.com> <553901BC.3040001@oracle.com> <20150511082120.GA13145@gmail.com> <20150511123117.GD4795@arm.com> <20150511123304.GA28716@gmail.com> <20150511155814.GA2724@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150511155814.GA2724@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2340 Lines: 60 Em Mon, May 11, 2015 at 12:58:14PM -0300, acme@redhat.com escreveu: > Em Mon, May 11, 2015 at 02:33:04PM +0200, Ingo Molnar escreveu: > > > That was already proposed here (as part of the fallback from getconf): > > > > > > https://lkml.kernel.org/r/20150427190356.GD474@krava.redhat.com > > > > > > but I'm not sure what happened to the patch. > > > > Sending out the latest/best version as a reminder for Arnaldo will > > sure help it along. > > > > Acked-by: Ingo Molnar > > IIRC it was merged already, lemme check... Yes, only for perf/core: [acme@zoo linux]$ git show 762abdc0c6c013425958cd9f5105f4e32268d434 commit 762abdc0c6c013425958cd9f5105f4e32268d434 Author: Will Deacon Date: Thu Apr 23 15:00:16 2015 +0100 perf tools: Use getconf to determine number of online CPUs Parsing /proc/cpuinfo is a fiddly, arch-dependent business and a recent change to get it working for Sparc broke arm and arm64 platforms. Use sysconf to determine the number of online CPUs only parsing /proc/cpuinfo when sysconf is not available. Signed-off-by: Will Deacon Acked-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Mark Rutland Cc: Namhyung Kim Link: http://lkml.kernel.org/r/20150423140454.GJ1652@arm.com [ Made it fall back to parsing /proc when getconf not found ] Signed-off-by: Arnaldo Carvalho de Melo diff --git a/tools/perf/Makefile b/tools/perf/Makefile index c699dc35eef9..d31a7bbd7cee 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -24,7 +24,7 @@ unexport MAKEFLAGS # (To override it, run 'make JOBS=1' and similar.) # ifeq ($(JOBS),) - JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null) + JOBS := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU[0-9]' /proc/cpuinfo) 2>/dev/null) ifeq ($(JOBS),0) JOBS := 1 endif [acme@zoo linux]$ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/