Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbbEKQJ7 (ORCPT ); Mon, 11 May 2015 12:09:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34644 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbEKQJ5 (ORCPT ); Mon, 11 May 2015 12:09:57 -0400 Date: Mon, 11 May 2015 18:09:55 +0200 From: David Sterba To: Omar Sandoval Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo Subject: Re: [PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options Message-ID: <20150511160955.GS23255@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Omar Sandoval , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qu Wenruo References: <40c40f7f26acb30eea471b8c7b7bc01cce74be4d.1428614837.git.osandov@osandov.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40c40f7f26acb30eea471b8c7b7bc01cce74be4d.1428614837.git.osandov@osandov.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 726 Lines: 15 On Thu, Apr 09, 2015 at 02:34:54PM -0700, Omar Sandoval wrote: > There's nothing to stop a user from passing both subvol= and subvolid= > to mount, but if they don't refer to the same subvolume, someone is > going to be surprised at some point. Error out on this case, but allow > users to pass in both if they do match (which they could, for example, > get out of /proc/mounts). > > Signed-off-by: Omar Sandoval Reviewed-by: David Sterba -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/