Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbbEKQa7 (ORCPT ); Mon, 11 May 2015 12:30:59 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:63544 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbEKQa4 (ORCPT ); Mon, 11 May 2015 12:30:56 -0400 From: Arnd Bergmann To: Baolin Wang Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH v3 05/22] posix-timers:Convert to the 64bit methods for the timer_gettime syscall function Date: Mon, 11 May 2015 18:30:52 +0200 Message-ID: <3090730.Lc4aTu6C4b@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1431342914-29569-1-git-send-email-baolin.wang@linaro.org> References: <1431342914-29569-1-git-send-email-baolin.wang@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:voz6ohpQ9kOzRi5XFed6IP4CkT+HwTxT54ucKFnnBhZDeVd4nvh lEXBe66AMFiF6jVzct/KQTasp8rroHcKMh3j/Z9yW0bS6y3FZNJMf7jjkGKRJcti7kw7zwB gR/LNcEz6Hikqksla1I4xVkGp4p/uX4L0mz2A+zg5jCI/DfT5dQdMLIFrOSbxgVlcJTAQPd aCgq9TUzbuNP+TnnCWBcA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 20 On Monday 11 May 2015 19:15:14 Baolin Wang wrote: > +static int default_timer_get64(struct k_itimer *timr, > + struct itimerspec64 *cur_setting64) > +{ > + struct itimerspec cur_setting; > + struct k_clock *kc = clockid_to_kclock(timr->it_clock); > + > + kc->timer_get(timr, &cur_setting); > + return 0; > +} This function is unfortunately incorrect, because you never copy the cur_setting value into cur_setting64. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/