Date: Mon, 11 May 2015 11:42:23 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Seth Jennings <sjenning@redhat.com>, Jiri Kosina <jkosina@suse.cz>,
        Vojtech Pavlik <vojtech@suse.cz>, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: match return value to function signature
Message-ID: <20150511164223.GA2746@treble.redhat.com>
References: <1431323549-27343-1-git-send-email-hofrat@osadl.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1431323549-27343-1-git-send-email-hofrat@osadl.org>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 45

On Mon, May 11, 2015 at 07:52:29AM +0200, Nicholas Mc Guire wrote:
> klp_initialized() should return bool but is actually returning 
> struct kobject * - convert it to a boolean explicitly.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> static code checking was not happy with
>  ./kernel/livepatch/core.c:131 WARNING: return of wrong type
>                                bool != struct kobject *
> 
> This adds !! to explicitly convert to boolean type.
> 
> Patch was compile tested with x86_64_defconfig
> 
> patch is against 4.1-rc2 (localversion-next is -next-20150508)
> 
>  kernel/livepatch/core.c     |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 0e7c23c..c0ae3d8 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -128,7 +128,7 @@ static bool klp_is_patch_registered(struct klp_patch *patch)
>  
>  static bool klp_initialized(void)
>  {
> -	return klp_root_kobj;
> +	return !!klp_root_kobj;
>  }
>  
>  struct klp_find_arg {
> -- 
> 1.7.10.4
> 

Thanks!

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/