Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbbEKQ6c (ORCPT ); Mon, 11 May 2015 12:58:32 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:59551 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbbEKQ6a (ORCPT ); Mon, 11 May 2015 12:58:30 -0400 Date: Mon, 11 May 2015 09:58:24 -0700 From: "Paul E. McKenney" To: Josh Triplett Cc: Nicholas Mc Guire , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] rcu: change function declaration to bool Message-ID: <20150511165823.GL6776@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1431359172-30126-1-git-send-email-hofrat@osadl.org> <20150511161159.GA14471@x> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150511161159.GA14471@x> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15051116-0013-0000-0000-00000AA9480F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2184 Lines: 59 On Mon, May 11, 2015 at 09:11:59AM -0700, Josh Triplett wrote: > On Mon, May 11, 2015 at 05:46:12PM +0200, Nicholas Mc Guire wrote: > > rcu_cpu_has_callbacks() is declared int but is actually returning bool > > and as the function description states " * Return true if the specified > > CPU has any callback....", this probably should be a bool. All (3) > > call-sites currently treat it as bool. > > > > Type-checking coccinelle spatches are being used to locate type mismatches > > between function signatures and return values in this case this produced: > > ./kernel/rcu/tree.c:3538 WARNING: return of wrong type > > int != bool, > > > > Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y) > > > > Patch is against 4.1-rc3 (localversion-next is -next-20150511) > > > > Signed-off-by: Nicholas Mc Guire > > Reviewed-by: Josh Triplett I queued V4 with Josh's Reviewed-by. I also capitalized the "change" following the "rcu:" in the Subject line. Thanx, Paul > Thanks! > > > --- > > > > V3: fix-up of commit message again (hope I got it right this time) as > > requested by Josh Triplett /Steven Rostedt > > > > > > kernel/rcu/tree.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index bcc5943..599550c 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -3516,7 +3516,7 @@ static int rcu_pending(void) > > * non-NULL, store an indication of whether all callbacks are lazy. > > * (If there are no callbacks, all of them are deemed to be lazy.) > > */ > > -static int __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy) > > +static bool __maybe_unused rcu_cpu_has_callbacks(bool *all_lazy) > > { > > bool al = true; > > bool hc = false; > > -- > > 1.7.10.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/