Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933019AbbEKSdK (ORCPT ); Mon, 11 May 2015 14:33:10 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:47102 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754953AbbEKSIT (ORCPT ); Mon, 11 May 2015 14:08:19 -0400 From: Al Viro To: Linus Torvalds Cc: Neil Brown , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v3 041/110] link_path_walk: massage a bit more Date: Mon, 11 May 2015 19:07:01 +0100 Message-Id: <1431367690-5223-41-git-send-email-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <20150511180650.GA4147@ZenIV.linux.org.uk> References: <20150511180650.GA4147@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 61 From: Al Viro Pull the block after the if-else in the end of what used to be do-while body into all branches there. We are almost done with the massage... Signed-off-by: Al Viro --- fs/namei.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 6a0dd07..b7ba718 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1803,6 +1803,8 @@ loop: /* will be gone very soon */ if (unlikely(!s)) { /* jumped */ put_link(nd, &link, cookie); + current->link_count--; + nd->depth--; } else { if (*s == '/') { if (!nd->root.mnt) @@ -1816,18 +1818,23 @@ loop: /* will be gone very soon */ err = link_path_walk(s, nd); if (unlikely(err)) { put_link(nd, &link, cookie); + current->link_count--; + nd->depth--; + return err; } else { err = walk_component(nd, LOOKUP_FOLLOW); put_link(nd, &link, cookie); - if (err > 0) + current->link_count--; + nd->depth--; + if (err < 0) + return err; + if (err > 0) { + current->link_count++; + nd->depth++; goto loop; + } } } - - current->link_count--; - nd->depth--; - if (err) - return err; } if (!d_can_lookup(nd->path.dentry)) { err = -ENOTDIR; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/