Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbbEKS4I (ORCPT ); Mon, 11 May 2015 14:56:08 -0400 Received: from lists.s-osg.org ([54.187.51.154]:49600 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbbEKSzn (ORCPT ); Mon, 11 May 2015 14:55:43 -0400 Message-ID: <5550FB2C.1000403@osg.samsung.com> Date: Mon, 11 May 2015 12:55:40 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Darren Hart , linux-api@vger.kernel.org, Linux Kernel Mailing List CC: Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Davidlohr Bueso , KOSAKI Motohiro , Shuah Khan Subject: Re: [PATCH 1/5] selftests: Add futex functional tests References: <57d921b1c30e8258ca4b2f55637424527317e92f.1431121818.git.dvhart@linux.intel.com> <5550EF8D.8080403@osg.samsung.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4206 Lines: 112 On 05/11/2015 12:22 PM, Darren Hart wrote: > On 5/11/15, 11:06 AM, "Shuah Khan" wrote: > >> On 05/08/2015 04:09 PM, Darren Hart wrote: >>> The futextest testsuite [1] provides functional, stress, and >>> performance tests for the various futex op codes. Those tests will be of >>> more use to futex developers if they are included with the kernel >>> source. >>> >>> Copy the core infrastructure and the functional tests into selftests, >>> but adapt them for inclusion in the kernel: >>> >>> - Update the Makefile to include the run_tests target, remove reference >>> to the performance and stress tests from the contributed sources. >>> - Replace my dead IBM email address with my current Intel email address. >>> - Remove the warrantee and write-to paragraphs from the license blurbs. >>> - Remove the NAME section as the filename is easily determined. ;-) >>> - Make the whitespace usage consistent in a couple of places. >>> - Cleanup various CodingStyle violations. >>> >>> A future effort will explore moving the performance and stress tests >>> into the kernel. >>> >>> 1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git >>> >>> Cc: Shuah Khan >>> Cc: linux-api@vger.kernel.org >>> Cc: Ingo Molnar >>> Cc: Peter Zijlstra >>> Cc: Thomas Gleixner >>> Cc: Davidlohr Bueso >>> Cc: KOSAKI Motohiro >>> Signed-off-by: Darren Hart >>> --- >> >> Daren, >> >> I am seeing >> >> fatal: cannot convert from y to UTF-8 >> >> when I try to apply the patch. Did you use git send-email? > > Hi Shuah, > > I've seen that from one of my contributors earlier this month as well. I > dropped the Content... Header and it applied without problems. > > I created the patch using git format-patch and then sent them using git > send-email - via a script I've been using for years now... > > Checking the files locally: > $ file * > 0000-cover-letter.patch: ASCII text > 0001-selftests-Add-futex-functional-tests.patch: unified > diff output, UTF-8 Unicode text > 0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch: unified > diff output, ASCII text > 0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch: unified > diff output, ASCII text > 0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch: unified > diff output, ASCII text > 0005-kselftest-Add-exit-code-defines.patch: unified > diff output, ASCII text > > > This shows that only the first in UTF-8 and the rest are ASCII. I presume > this is due to the Copyright notices in the original files: > > Copyright ? International Business Machines Corp., 2006-2008 > > Which use ? instead of (C). I just checked and there are 545 instances of > ? in the kernel itself, so this should not present a problem. > > I apologize for the glitch in applying. If you use the pull request I > included that will avoid the mail transport issues, and I will be sure to > fix my scripts to avoid the issue in the future. > > If you want to use the patches directly, please have a look at 1 of 5 and > just remove the "Content..." header, and I think you'll find "git am" will > apply it without complaint. > Hi Daren, Removing the Content header got me past the utf error. However, git am complains: git am --signoff ../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbox Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF. + warning: 1 line adds whitespace errors. Could you look into these. Rest of the patches applied fine. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/