Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbbEKVqH (ORCPT ); Mon, 11 May 2015 17:46:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59392 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbEKVqG (ORCPT ); Mon, 11 May 2015 17:46:06 -0400 Date: Mon, 11 May 2015 23:46:04 +0200 (CEST) From: Jiri Kosina To: Nicholas Mc Guire cc: Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: match return value to function signature In-Reply-To: <1431323549-27343-1-git-send-email-hofrat@osadl.org> Message-ID: References: <1431323549-27343-1-git-send-email-hofrat@osadl.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 28 On Mon, 11 May 2015, Nicholas Mc Guire wrote: > klp_initialized() should return bool but is actually returning > struct kobject * - convert it to a boolean explicitly. > > Signed-off-by: Nicholas Mc Guire > --- > > static code checking was not happy with > ./kernel/livepatch/core.c:131 WARNING: return of wrong type > bool != struct kobject * > > This adds !! to explicitly convert to boolean type. > > Patch was compile tested with x86_64_defconfig > > patch is against 4.1-rc2 (localversion-next is -next-20150508) Applied to for-4.2/upstream. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/