Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbbEKVqp (ORCPT ); Mon, 11 May 2015 17:46:45 -0400 Received: from gloria.sntech.de ([95.129.55.99]:51764 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbbEKVqm (ORCPT ); Mon, 11 May 2015 17:46:42 -0400 From: Heiko Stuebner To: Javier Martinez Canillas Cc: Gwendal Grignou , Lee Jones , Samuel Ortiz , Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Stephen Barber , Filipe Brandenburger , Todd Broch , Alexandru M Stan , linux-samsung-soc@vger.kernel.org, Linux Kernel Subject: Re: [PATCH v2 04/10] mfd: cros_ec: Use a zero-length array for command data Date: Mon, 11 May 2015 23:47:25 +0200 Message-ID: <4091454.JTEcLO5LxH@phil> User-Agent: KMail/4.14.1 (Linux/3.19.0+; KDE/4.14.2; x86_64; ; ) In-Reply-To: <55512034.3000206@collabora.co.uk> References: <1431166241-15775-1-git-send-email-javier.martinez@collabora.co.uk> <55512034.3000206@collabora.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1365 Lines: 39 > Heiko, Alexandru, > > I don't have access to my Chromebooks right now but could you please test > the following patch [0] to see if that is the problem? > > It seems I got it working on my test just out of luck since it happened that > version was initialized to 0 due the data it was on the stack. > > Tomorrow when I've access to the Chromebooks I'll do more extensive testing > and see if I can reproduce the issue and if my assumption is correct. > > Best regards, > Javier > > [0] > diff --git a/drivers/input/keyboard/cros_ec_keyb.c > b/drivers/input/keyboard/cros_ec_keyb.c index ef3ba20f4560..4f233e248a4d > 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -151,6 +151,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb > *ckdev, uint8_t *kb_state) int ret; > struct cros_ec_command *msg = (struct cros_ec_command *)kb_state; > > + msg->version = 0; > msg->command = EC_CMD_MKBP_STATE; > msg->insize = ckdev->cols; > msg->outsize = 0; on my rk3288-pinky this seems to fix the issue ... keyboard works out of the box again. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/