Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbbEKVxp (ORCPT ); Mon, 11 May 2015 17:53:45 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:43529 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbbEKVxo (ORCPT ); Mon, 11 May 2015 17:53:44 -0400 Message-ID: <555124DE.8030003@collabora.co.uk> Date: Mon, 11 May 2015 23:53:34 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Gwendal Grignou , Lee Jones , Samuel Ortiz , Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Stephen Barber , Filipe Brandenburger , Todd Broch , Alexandru M Stan , linux-samsung-soc@vger.kernel.org, Linux Kernel Subject: Re: [PATCH v2 04/10] mfd: cros_ec: Use a zero-length array for command data References: <1431166241-15775-1-git-send-email-javier.martinez@collabora.co.uk> <55512034.3000206@collabora.co.uk> <4091454.JTEcLO5LxH@phil> In-Reply-To: <4091454.JTEcLO5LxH@phil> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1700 Lines: 52 Hello Heiko and Alexandru, On 05/11/2015 11:47 PM, Heiko Stuebner wrote: >> Heiko, Alexandru, >> >> I don't have access to my Chromebooks right now but could you please test >> the following patch [0] to see if that is the problem? >> >> It seems I got it working on my test just out of luck since it happened that >> version was initialized to 0 due the data it was on the stack. >> >> Tomorrow when I've access to the Chromebooks I'll do more extensive testing >> and see if I can reproduce the issue and if my assumption is correct. >> >> Best regards, >> Javier >> >> [0] >> diff --git a/drivers/input/keyboard/cros_ec_keyb.c >> b/drivers/input/keyboard/cros_ec_keyb.c index ef3ba20f4560..4f233e248a4d >> 100644 >> --- a/drivers/input/keyboard/cros_ec_keyb.c >> +++ b/drivers/input/keyboard/cros_ec_keyb.c >> @@ -151,6 +151,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb >> *ckdev, uint8_t *kb_state) int ret; >> struct cros_ec_command *msg = (struct cros_ec_command *)kb_state; >> >> + msg->version = 0; >> msg->command = EC_CMD_MKBP_STATE; >> msg->insize = ckdev->cols; >> msg->outsize = 0; > > on my rk3288-pinky this seems to fix the issue ... keyboard works out of the > box again. > Thank you both for testing the fix and again sorry for the silly mistake... I'll wait a couple of days to see if I get more feedback and re-spin a v3 of the series with this fix patch squashed. > > Heiko > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/