Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbbEKWOu (ORCPT ); Mon, 11 May 2015 18:14:50 -0400 Received: from mail-bn1bon0147.outbound.protection.outlook.com ([157.56.111.147]:64943 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752621AbbEKWOs (ORCPT ); Mon, 11 May 2015 18:14:48 -0400 Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none; Message-ID: <1431382467.16357.476.camel@freescale.com> Subject: Re: [PATCH v3 3/3] kvm/powerpc: Export HCALL reason codes From: Scott Wood To: Hemant Kumar CC: , , , , , , , , , , , Date: Mon, 11 May 2015 17:14:27 -0500 In-Reply-To: <1431046385-5772-3-git-send-email-hemant@linux.vnet.ibm.com> References: <1431046385-5772-1-git-send-email-hemant@linux.vnet.ibm.com> <1431046385-5772-3-git-send-email-hemant@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:2:5800:3f7:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BN3PR0401CA0008.namprd04.prod.outlook.com (25.162.159.146) To BY1PR03MB1484.namprd03.prod.outlook.com (25.162.210.142) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BY1PR03MB1484;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1484; X-Forefront-PRVS: 05739BA1B5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(19580405001)(33646002)(47776003)(110136002)(5820100001)(103116003)(40100003)(23676002)(50466002)(46102003)(19580395003)(77156002)(86362001)(122386002)(189998001)(42186005)(87976001)(62966003)(5001960100002)(76176999)(36756003)(92566002)(50986999)(50226001)(2950100001)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1484;H:[IPv6:2601:2:5800:3f7:12bf:48ff:fe84:c9a0];FPR:;SPF:None;MLV:sfv;LANG:en; X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2015 22:14:43.6430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1484 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1783 Lines: 48 On Fri, 2015-05-08 at 06:23 +0530, Hemant Kumar wrote: > For perf to analyze the KVM events like hcalls, we need the > hypervisor calls and their codes to be exported through uapi. > > This patch moves most of the pSeries hcall codes from > arch/powerpc/include/asm/hvcall.h to > arch/powerpc/include/uapi/asm/hcall_codes.h. > It also moves the mapping from > arch/powerpc/kvm/trace_hv.h to > arch/powerpc/include/uapi/asm/trace_hcall.h. > > Signed-off-by: Hemant Kumar > --- > arch/powerpc/include/asm/hvcall.h | 120 +-------------------------- > arch/powerpc/include/uapi/asm/hcall_codes.h | 123 ++++++++++++++++++++++++++++ > arch/powerpc/include/uapi/asm/trace_hcall.h | 122 +++++++++++++++++++++++++++ > arch/powerpc/kvm/trace_hv.h | 117 +------------------------- When moving to uapi please add proper namespacing to indicate that this is pseries specific. > diff --git a/arch/powerpc/include/uapi/asm/trace_hcall.h b/arch/powerpc/include/uapi/asm/trace_hcall.h > new file mode 100644 > index 0000000..00eac01 > --- /dev/null > +++ b/arch/powerpc/include/uapi/asm/trace_hcall.h > @@ -0,0 +1,122 @@ > +#ifndef _KVM_TRACE_HCALL_MAP_H > +#define _KVM_TRACE_HCALL_MAP_H > + > +#include "hcall_codes.h" > + > +#define kvm_trace_symbol_hcall\ > + {H_REMOVE,"H_REMOVE"}, \ > + {H_ENTER,"H_ENTER"}, \ > + {H_READ,"H_READ"}, \ > + {H_CLEAR_MOD,"H_CLEAR_MOD"}, \ This is a rather odd way of exposing an array to userspace... -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/