Date: Mon, 11 May 2015 16:23:16 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vsprintf: Add support for userspace strings
Message-Id: <20150511162316.10df1028c6afae6f4a37747f@linux-foundation.org>
In-Reply-To: <1431288982.29257.31.camel@perches.com>
References: <1431286936-4333-1-git-send-email-richard@nod.at>
	<1431286936-4333-3-git-send-email-richard@nod.at>
	<1431288580.29257.29.camel@perches.com>
	<554FBB8F.3070204@nod.at>
	<1431288982.29257.31.camel@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 29

On Sun, 10 May 2015 13:16:22 -0700 Joe Perches <joe@perches.com> wrote:

> On Sun, 2015-05-10 at 22:11 +0200, Richard Weinberger wrote:
> > Am 10.05.2015 um 22:09 schrieb Joe Perches:
> > > On Sun, 2015-05-10 at 21:42 +0200, Richard Weinberger wrote:
> > >> Add %pL format string to print userspace strings.
> > >> It works like %s but does copy_from_user() instead
> > >> of a memcpy().
> > > 
> > > I think this would be much simpler in a new
> > > function rather than complicating string()
> > 
> > -ENOPATCH.
> 
> It's your patch, I'm just commenting on it.
> 
> I'm not sure there's much value in it.

I can't say I'm terribly excited either.  Are there any existing
callsites which might use this?  The %p namespace is already pretty
crowded and if %pL is just for non-production developer debug use then
it can reasonably live outside the main kernel tree...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/