Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbbELGkt (ORCPT ); Tue, 12 May 2015 02:40:49 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:34552 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbbELGkp (ORCPT ); Tue, 12 May 2015 02:40:45 -0400 MIME-Version: 1.0 In-Reply-To: <20150511143309.GA22341@krava.redhat.com> References: <1431336927-17202-1-git-send-email-hekuang@huawei.com> <20150511143309.GA22341@krava.redhat.com> Date: Tue, 12 May 2015 08:40:44 +0200 Message-ID: Subject: Re: [PATCH 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins From: Mathias Krause To: Jiri Olsa Cc: He Kuang , jolsa@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Ingo Molnar , wangnan0@huawei.com, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 30 On 11 May 2015 at 16:33, Jiri Olsa wrote: > On Mon, May 11, 2015 at 09:35:26AM +0000, He Kuang wrote: >> Traceevent plugins need dynamic symbols exported from libtraceevent.a, >> otherwise a dlopen error will occur during plugins loading. >> >> This patch uses dynamic-list-file to export dynamic symbols which will >> be used in plugins to perf executable. >> >> The problem is covered up if feature-libpython is enabled, because >> PYTHON_EMBED_LDOPTS contains '-Xlinker --export-dynamic' which adds all >> symbols to the dynamic symbol table. So we should reproduce the problem >> by setting NO_LIBPYTHON=1. > > there's was another patch taking the shortcut: > http://marc.info/?l=linux-kernel&m=142885447432384&w=2 > > it seems it's not merged yet, but I like this one better > I don't care much as long as it get fixed -- either using the big hammer with -Wl,--export-dynamic or the fine grained approach using a symbol file. Thanks, Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/