Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932273AbbELHtC (ORCPT ); Tue, 12 May 2015 03:49:02 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35147 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbbELHs6 convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2015 03:48:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <1430986090-7243-1-git-send-email-geert@linux-m68k.org> <1430986090-7243-2-git-send-email-geert@linux-m68k.org> Date: Tue, 12 May 2015 09:48:57 +0200 X-Google-Sender-Auth: 2_HB_HUHX-JROnyR7vCEgNk6U3I Message-ID: Subject: Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface From: Geert Uytterhoeven To: Bryan Wu Cc: Linus Walleij , Alexandre Courbot , Richard Purdie , Arnd Bergmann , Jacek Anaszewski , "linux-gpio@vger.kernel.org" , Linux LED Subsystem , lkml Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 33 Hi Bryan, On Fri, May 8, 2015 at 7:43 PM, Bryan Wu wrote: > On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven wrote: >> If GPIOLIB=n: >> >> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: >> drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’ >> drivers/leds/leds-gpio.c:187: warning: assignment makes pointer from integer without a cast >> >> Add dummies for fwnode_get_named_gpiod() and devm_get_gpiod_from_child() >> for the !GPIOLIB case to fix this. > > This patch looks good to me. Do you mind merging it through LED tree > with other 2 more LED patches? Now we have an ack from Alex, that's fine for me. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/