Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753338AbbELH5P (ORCPT ); Tue, 12 May 2015 03:57:15 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35154 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbbELH5N (ORCPT ); Tue, 12 May 2015 03:57:13 -0400 Date: Tue, 12 May 2015 09:57:08 +0200 From: Hagen Paul Pfeifer To: Denys Vlasenko Cc: Ingo Molnar , Steven Rostedt , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: force inlining of atomic ops Message-ID: <20150512075708.GA6969@virgo.local> References: <1431080762-17797-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431080762-17797-1-git-send-email-dvlasenk@redhat.com> X-Key-Id: 98350C22 X-Key-Fingerprint: 490F 557B 6C48 6D7E 5706 2EA2 4A22 8D45 9835 0C22 X-GPG-Key: gpg --recv-keys --keyserver wwwkeys.eu.pgp.net 98350C22 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 26 * Denys Vlasenko | 2015-05-08 12:26:02 [+0200]: [snip] >With both gcc 4.7.2 and 4.9.2, sometimes gcc mysteriously doesn't inline >This patch fixes this for x86 atomic ops via s/inline/__always_inline/. >This decreases allyesconfig kernel by about 25k: > > text data bss dec hex filename >82399481 22255416 20627456 125282353 777a831 vmlinux.before >82375570 22255544 20627456 125258570 7774b4a vmlinux atomic_inc, atomic_sub, atomic_add, atomic_sub_and_test, atomic_dec, atomic_dec_and_test, atomic_add_return, __atomic_add_unless, atomic64_add, atomic64_inc, atomic64_dec, atomic64_add_return are already annotated with __always_inline. This patch will lead to merge conflicts someone, Ingo? See https://lkml.org/lkml/2015/4/20/637 Hagen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/