Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932202AbbELJYh (ORCPT ); Tue, 12 May 2015 05:24:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54207 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbbELJYe (ORCPT ); Tue, 12 May 2015 05:24:34 -0400 Message-ID: <5551B4EE.8020000@redhat.com> Date: Tue, 12 May 2015 10:08:14 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Xiao Guangrong CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/9] KVM: MMU: introduce for_each_rmap_spte() References: <1431397953-16642-1-git-send-email-guangrong.xiao@linux.intel.com> <1431397953-16642-3-git-send-email-guangrong.xiao@linux.intel.com> In-Reply-To: <1431397953-16642-3-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 718 Lines: 24 On 12/05/2015 04:32, Xiao Guangrong wrote: > - while ((sptep = rmap_get_first(*rmapp, &iter))) { > - BUG_ON(!(*sptep & PT_PRESENT_MASK)); > +restart: > + for_each_rmap_spte(rmapp, &iter, sptep) { > rmap_printk("kvm_rmap_unmap_hva: spte %p %llx gfn %llx (%d)\n", > sptep, *sptep, gfn, level); > > drop_spte(kvm, sptep); > need_tlb_flush = 1; > + goto restart; > } > For this one, I would keep using rmap_get_first. Otherwise looks good. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/