Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbbELJ2v (ORCPT ); Tue, 12 May 2015 05:28:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932435AbbELJ2r (ORCPT ); Tue, 12 May 2015 05:28:47 -0400 Message-ID: <5551B842.6060807@redhat.com> Date: Tue, 12 May 2015 10:22:26 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Xiao Guangrong CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/9] KVM: MMU: introduce slot_handle_level_range() and its helpers References: <1431397953-16642-1-git-send-email-guangrong.xiao@linux.intel.com> <1431397953-16642-5-git-send-email-guangrong.xiao@linux.intel.com> In-Reply-To: <1431397953-16642-5-git-send-email-guangrong.xiao@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 491 Lines: 17 On 12/05/2015 04:32, Xiao Guangrong wrote: > + if (iterator.rmap) > + flush |= fn(kvm, iterator.rmap); > + > + if (need_resched() || spin_needbreak(&kvm->mmu_lock)) { > + if (flush & lock_flush_tlb) { &&, not &. (Cosmetic only). Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/