Message-id: <5551BF04.5010503@samsung.com>
Date: Tue, 12 May 2015 10:51:16 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: "Kim, Milo" <milo.kim@ti.com>
Cc: Toshi Kikuchi <toshik@chromium.org>, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org, Bryan Wu <cooloney@gmail.com>
Subject: Re: [PATCH] leds: lp5523: add master_fader support
References: <1431371454-2035-1-git-send-email-toshik@chromium.org>
 <5551AAFA.5080807@samsung.com> <5551B8F9.6040808@ti.com>
In-reply-to: <5551B8F9.6040808@ti.com>
Content-type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1145
Lines: 37

On 05/12/2015 10:25 AM, Kim, Milo wrote:
> Hi Jacek and Toshi,
>
> On 5/12/2015 4:25 PM, Jacek Anaszewski wrote:
>> Hi Toshi,
>>
>> On 05/11/2015 09:10 PM, Toshi Kikuchi wrote:
>>> This patch introduces 4 new attributes:
>>>     master_fader_leds
>>>     master_fader1
>>>     master_fader2
>>>     master_fader3
>>>
>>> Fo example, to map channel 0,6 to master_fader1,
>>> map channel 1,7 to master_fader2,
>>> map channel 2,8 to master_fader3, and
>>> map channel 3,4,5 to none
>>   >
>>>     echo "123000123" > master_fader_leds
>>
>> I propose to add ABI documentation for this driver. It already exposes
>> many custom attributes but I can't find documentation for them.
>
> I agree with Jacek's comment but it would be better if we could see the
> description in lp5523 driver
> documentation(Documentation/leds/leds-lp5523.txt).

Right, I missed that file.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/