Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932541AbbELIwV (ORCPT ); Tue, 12 May 2015 04:52:21 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:62388 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752676AbbELIwT (ORCPT ); Tue, 12 May 2015 04:52:19 -0400 From: Arnd Bergmann To: Baolin Wang Cc: tglx@linutronix.de, john.stultz@linaro.org, heenasirwani@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH v3 15/22] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Date: Tue, 12 May 2015 10:51:38 +0200 Message-ID: <9198494.K1zFNegC4D@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1431343239-29961-1-git-send-email-baolin.wang@linaro.org> References: <1431343239-29961-1-git-send-email-baolin.wang@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:V7BUz4yk0oLU5LgPC5fRssyFK9kGpY2pX4j0WbSczvwPovFjR9J QaBhKNJyNit3cLECGIj3HZy87yeGBQDppCvR9qeG+Ygg4rys0AzNgQbFaYjgTu8q9O5OCI+ FV1YS4vzqFPQdk1J3xHyWjWVD9EMn7IaZaCQxvdUOAgiERnd5VurqS2QJPAJZZddtQsPjYw fdwGtNUcIQ9q4wgLan+ZQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 35 On Monday 11 May 2015 19:20:39 Baolin Wang wrote: > diff --git a/include/linux/timekeeping.h b/include/linux/timekeeping.h > index 89beb62..c3345d5 100644 > --- a/include/linux/timekeeping.h > +++ b/include/linux/timekeeping.h > @@ -250,9 +250,9 @@ static inline void get_monotonic_boottime64(struct timespec64 *ts) > *ts = ktime_to_timespec64(ktime_get_boottime()); > } > > -static inline void timekeeping_clocktai(struct timespec *ts) > +static inline void timekeeping_clocktai(struct timespec64 *ts) > { > - *ts = ktime_to_timespec(ktime_get_clocktai()); > + *ts = ktime_to_timespec64(ktime_get_clocktai()); > } > > /* > I believe Thomas has already mentioned before that the change to the timekeeping_clocktai() function is not obvious here. I'd suggest you split out the changes here along with the posix_get_tai() that calls it into its own patch with a good description, and leave all the simple changes to kernel/time/posix-timers.c in a second patch. I don't think it's necessary to split up the other changes from this patch any further. If Thomas or someone else disagrees with this and wants it more fine-grained, it would be good to say that now. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/