Message-ID: <1431421534.2398.147.camel@x220>
Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC
From: Paul Bolle <pebolle@tiscali.nl>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Date: Tue, 12 May 2015 11:05:34 +0200
In-Reply-To: <1431361537-10473-2-git-send-email-ulli.kroll@googlemail.com>
References: <1431361537-10473-1-git-send-email-ulli.kroll@googlemail.com>
	 <1431361537-10473-2-git-send-email-ulli.kroll@googlemail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1278
Lines: 39

On Mon, 2015-05-11 at 18:25 +0200, Hans Ulli Kroll wrote:
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig

> +config RTC_DRV_GEMINI
> +	tristate "Gemini SoC RTC"
> +	help
> +	  If you say Y here you will get support for the
> +	  RTC found on Gemini SoC's.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called rtc-gemini.

This has, by the look of it, very little dependencies, probably just
RTC_CLASS. So I think that this symbol can be enabled in allyesconfig,
allmodconfig, and randconfig for most architectures. (I just tested this
- what a novel idea! - and it will indeed be set by allyesconfig and
allmodconfig on x86_64.)

> --- /dev/null
> +++ b/drivers/rtc/rtc-gemini.c

> +#include <mach/hardware.h>

Except for arm, builds using a .config containing
    CONFIG_RTC_DRV_GEMINI=[my]

will fail here. (*/mach/hardware.h is mainly used for arm.) That is
bound to generate, well, fanmail for you. Perhaps it's better if
RTC_DRV_GEMINI depends on, say, ARCH_GEMINI.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/