Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbbELJU1 (ORCPT ); Tue, 12 May 2015 05:20:27 -0400 Received: from mta-out1.inet.fi ([62.71.2.195]:49725 "EHLO jenni2.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbbELJUY (ORCPT ); Tue, 12 May 2015 05:20:24 -0400 Date: Tue, 12 May 2015 12:19:51 +0300 From: "Kirill A. Shutemov" To: "Aneesh Kumar K.V" Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, kirill.shutemov@linux.intel.com, aarcange@redhat.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 1/3] mm/thp: Split out pmd collpase flush into a separate functions Message-ID: <20150512091951.GA18365@node.dhcp.inet.fi> References: <1431410914-21102-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431410914-21102-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 32 On Tue, May 12, 2015 at 11:38:32AM +0530, Aneesh Kumar K.V wrote: > Architectures like ppc64 [1] need to do special things while clearing > pmd before a collapse. For them this operation is largely different > from a normal hugepage pte clear. Hence add a separate function > to clear pmd before collapse. After this patch pmdp_* functions > operate only on hugepage pte, and not on regular pmd_t values > pointing to page table. > > [1] ppc64 needs to invalidate all the normal page pte mappings we > already have inserted in the hardware hash page table. But before > doing that we need to make sure there are no parallel hash page > table insert going on. So we need to do a kick_all_cpus_sync() > before flushing the older hash table entries. By moving this to > a separate function we capture these details and mention how it > is different from a hugepage pte clear. > > This patch is a cleanup and only does code movement for clarity. > There should not be any change in functionality. > > Signed-off-by: Aneesh Kumar K.V For the patchset: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/