Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbbELJYy (ORCPT ); Tue, 12 May 2015 05:24:54 -0400 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:54413 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810AbbELJYf (ORCPT ); Tue, 12 May 2015 05:24:35 -0400 Message-ID: <1431422671.2398.155.camel@x220> Subject: Re: [PATCH 1/5] soc: mediatek: Add infracfg misc driver support From: Paul Bolle To: Sascha Hauer Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger Date: Tue, 12 May 2015 11:24:31 +0200 In-Reply-To: <1431372206-1237-2-git-send-email-s.hauer@pengutronix.de> References: <1431372206-1237-1-git-send-email-s.hauer@pengutronix.de> <1431372206-1237-2-git-send-email-s.hauer@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 43 On Mon, 2015-05-11 at 21:23 +0200, Sascha Hauer wrote: > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > +config MTK_INFRACFG > + tristate "MediaTek INFRACFG Support" > + depends on ARCH_MEDIATEK > + select REGMAP > + help > + Say yes here to add support for the MediaTek INFRACFG controller. The > + INFRACFG controller contains various infrastructure registers not > + directly associated to any device. > --- a/drivers/soc/mediatek/Makefile > +++ b/drivers/soc/mediatek/Makefile > +obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o > --- /dev/null > +++ b/drivers/soc/mediatek/mtk-infracfg.c > +EXPORT_SYMBOL_GPL(mtk_infracfg_set_bus_protection); > +EXPORT_SYMBOL_GPL(mtk_infracfg_clear_bus_protection); As I understand it, if both MTK_INFRACFG and MTK_SCPSYS (see 3/5) are m we will get mtk-infracfg.ko and mtk-scpsys.ko (see 3/5). And loading mtk-scpsys.ko will trigger loading mtk-infracfg.ko, right? But since this file has no MODULE_LICENSE() that should generate a warning and taint the kernel. (I haven't tested this. Please correct me if I'm overlooking something here.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/