Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932783AbbELJdi (ORCPT ); Tue, 12 May 2015 05:33:38 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:52365 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932410AbbELJ2J (ORCPT ); Tue, 12 May 2015 05:28:09 -0400 From: Arnd Bergmann To: Paul Bolle Cc: Hans Ulli Kroll , Alexandre Belloni , linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC Date: Tue, 12 May 2015 11:28:04 +0200 Message-ID: <3450432.fQTk5fWsso@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1431421534.2398.147.camel@x220> References: <1431361537-10473-1-git-send-email-ulli.kroll@googlemail.com> <1431361537-10473-2-git-send-email-ulli.kroll@googlemail.com> <1431421534.2398.147.camel@x220> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:VscUeKNhXGPJ4IMixvapSOb8DNZdFMM6kE8GrQTstCUlj96z74g HfVcnYOMhQjrh3bz2X2DS50IcOPUqkDTcGXBOJmhPt3qsUVt8s3VDAeEJZKhB09Enb3BATR Fm6293BvOnInHqorpSsyb+R6E927y396tjHoASWQC6obx5zPkMgtHMmftZoN9HJB4OOrqyJ AlAEOvKCbKH1sYLYyVEPA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1950 Lines: 54 On Tuesday 12 May 2015 11:05:34 Paul Bolle wrote: > On Mon, 2015-05-11 at 18:25 +0200, Hans Ulli Kroll wrote: > > --- a/drivers/rtc/Kconfig > > +++ b/drivers/rtc/Kconfig > > > +config RTC_DRV_GEMINI > > + tristate "Gemini SoC RTC" > > + help > > + If you say Y here you will get support for the > > + RTC found on Gemini SoC's. > > + > > + This driver can also be built as a module. If so, the module > > + will be called rtc-gemini. > > This has, by the look of it, very little dependencies, probably just > RTC_CLASS. So I think that this symbol can be enabled in allyesconfig, > allmodconfig, and randconfig for most architectures. (I just tested this > - what a novel idea! - and it will indeed be set by allyesconfig and > allmodconfig on x86_64.) > > > --- /dev/null > > +++ b/drivers/rtc/rtc-gemini.c > > > +#include > > Except for arm, builds using a .config containing > CONFIG_RTC_DRV_GEMINI=[my] > > will fail here. (*/mach/hardware.h is mainly used for arm.) That is > bound to generate, well, fanmail for you. Perhaps it's better if > RTC_DRV_GEMINI depends on, say, ARCH_GEMINI. Well spotted, thanks for the report. I have a patch that will turn mach-gemini into multiplatform, and at that point it will also fail there. The correct solution I think is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c itself and remove the #include. It still makes sense to have a dependency, but I'd express it as depends on ARCH_GEMINI || COMPILE_TEST in order to let the driver get compiled for an allyesconfig kernel on all architectures, but not appear as an option for normal builds that do not set COMPILE_TEST. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/